Skip to content

Bind the Required Check Name and Bump the Hub Task Pins - #597

Merged
ptr727 merged 3 commits into
developfrom
chore/required-check-event-name
Nov 11, 2026
Merged

ptr727 merged 3 commits into
developfrom
chore/required-check-event-name

Conversation

@ptr727

@ptr727 ptr727 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes the one interface finding from the fleet resync audit (audit run 2026-11-11T00:47:02Z | hub 1397e30a | branch override develop), and moves Blog onto the hub release that resync carries.

  • Required check name. test-pull-request.yml also runs on workflow_dispatch, so a dispatch on a pull request's head could post the ruleset-bound Check pull request workflow status job context without that pull request's gates. The job name: is now the expression WORKFLOW.md D1.5 requires. A pull_request run keeps the bound name, and any other run reports Check workflow status job. Two comment lines say which run takes the bound name, which is why this carries the comments label.
  • Hub task pins to 2.0.1388. The 2.0.1366 prose gate crashes at import on the markdown-it-py release it leaves unpinned, so every pull request's lint job here fails before it reads a file. 2.0.1388 fixes that and pins the package. All seven pins across test-pull-request.yml, publish-release.yml, deploy-site.yml, and merge-bot-pull-request.yml move together. No called task changes an input, secret, or output between the two releases. The only other changes are an action bump in build-release-task.yml and .NET steps that skip without a .csproj.
  • .gitignore. .vscode/settings.json joins it, per GOVERNANCE.md "Editor and Tasks" for a repository shipping Python. Nothing in the repository tracks that file.

Verification

  • prose_lint.py --diff, docker_lint.py (actionlint included), and repo_gate.py --check sha-pin pass, apart from the vendored PaperMod theme's own pins that CI excludes.
  • Local strict review passes at the frontier tier. The first raised that the aggregator comment no longer named which run takes the bound name, fixed in fa24b50.

🤖 Generated with Claude Code

WORKFLOW.md D1.5 reserves the ruleset-bound name for a pull_request run, so a workflow_dispatch on a pull request's head cannot post the required check without that pull request's gates. Also ignores the .vscode/settings.json the Python extension writes, per GOVERNANCE.md Editor and Tasks.
Copilot AI lite review requested due to automatic review settings November 11, 2026 00:54
@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head da5d7d37e1b6500ae333226a62fc0cf0c3b29aeb, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes appropriately scope the required status check to pull request events while ignoring untracked editor settings.

No open issues 🎉

What changed in this PR

This PR makes the required status-check name apply only to real pull request runs. The workflow test-pull-request.yml also runs on workflow_dispatch, so a manual run on a pull request's head could post the ruleset-bound Check pull request workflow status job context without that pull request's gates. The PR also ignores the editor settings file .vscode/settings.json, which the repository does not track.

Changes:

  • The check-workflow-status job name is now an expression. It keeps Check pull request workflow status job for pull_request runs and uses Check workflow status job for every other event.
  • .vscode/settings.json is added to .gitignore, matching the repository's editor-settings convention for Python repositories.
File Description
.gitignore Adds .vscode/settings.json so local editor settings stay untracked.
.github/​workflows/​test-pull-request.yml Makes the status-check job name depend on the event, so only pull_request runs post the required context.

Review effort: Lite

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.95%. Comparing base (5c551c4) to head (fa24b50).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #597   +/-   ##
========================================
  Coverage    66.95%   66.95%           
========================================
  Files           11       11           
  Lines         2503     2503           
========================================
  Hits          1676     1676           
  Misses         827      827           
Flag Coverage Δ
python-3.13 66.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The prose gate in 2.0.1366 crashes at import on the markdown-it-py release it leaves unpinned, so every pull request's lint job fails before reading a file. 2.0.1388 builds that pattern itself and pins the package. No pinned task changes an input between the two releases.
The aggregator comment named one bound name while the job now carries two, so a reader could not tell which string the ruleset binds.
@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Nov 11, 2026
@ptr727 ptr727 changed the title Bind the Required Check Name to Pull Request Runs Bind the Required Check Name and Bump the Hub Task Pins Nov 11, 2026
@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head fa24b507e9e57ddff508f1fd811363b3f4419c09, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727
ptr727 merged commit bd8781d into develop Nov 11, 2026
12 checks passed
@ptr727
ptr727 deleted the chore/required-check-event-name branch November 11, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants