Repository navigation
Bind the Required Check Name and Bump the Hub Task Pins - #597
Conversation
WORKFLOW.md D1.5 reserves the ruleset-bound name for a pull_request run, so a workflow_dispatch on a pull request's head cannot post the required check without that pull request's gates. Also ignores the .vscode/settings.json the Python extension writes, per GOVERNANCE.md Editor and Tasks.
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the changes appropriately scope the required status check to pull request events while ignoring untracked editor settings.
No open issues 🎉
What changed in this PR
This PR makes the required status-check name apply only to real pull request runs. The workflow test-pull-request.yml also runs on workflow_dispatch, so a manual run on a pull request's head could post the ruleset-bound Check pull request workflow status job context without that pull request's gates. The PR also ignores the editor settings file .vscode/settings.json, which the repository does not track.
Changes:
- The
check-workflow-statusjob name is now an expression. It keepsCheck pull request workflow status jobforpull_requestruns and usesCheck workflow status jobfor every other event. .vscode/settings.jsonis added to.gitignore, matching the repository's editor-settings convention for Python repositories.
| File | Description |
|---|---|
| .gitignore | Adds .vscode/settings.json so local editor settings stay untracked. |
| .github/workflows/test-pull-request.yml | Makes the status-check job name depend on the event, so only pull_request runs post the required context. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #597 +/- ##
========================================
Coverage 66.95% 66.95%
========================================
Files 11 11
Lines 2503 2503
========================================
Hits 1676 1676
Misses 827 827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The prose gate in 2.0.1366 crashes at import on the markdown-it-py release it leaves unpinned, so every pull request's lint job fails before reading a file. 2.0.1388 builds that pattern itself and pins the package. No pinned task changes an input between the two releases.
The aggregator comment named one bound name while the job now carries two, so a reader could not tell which string the ruleset binds.
|
A recorded local strict-review pass covers head |
Summary
Closes the one interface finding from the fleet resync audit (
audit run 2026-11-11T00:47:02Z | hub 1397e30a | branch override develop), and moves Blog onto the hub release that resync carries.test-pull-request.ymlalso runs onworkflow_dispatch, so a dispatch on a pull request's head could post the ruleset-boundCheck pull request workflow status jobcontext without that pull request's gates. The jobname:is now the expressionWORKFLOW.mdD1.5 requires. Apull_requestrun keeps the bound name, and any other run reportsCheck workflow status job. Two comment lines say which run takes the bound name, which is why this carries thecommentslabel.markdown-it-pyrelease it leaves unpinned, so every pull request's lint job here fails before it reads a file. 2.0.1388 fixes that and pins the package. All seven pins acrosstest-pull-request.yml,publish-release.yml,deploy-site.yml, andmerge-bot-pull-request.ymlmove together. No called task changes an input, secret, or output between the two releases. The only other changes are an action bump inbuild-release-task.ymland .NET steps that skip without a.csproj..gitignore..vscode/settings.jsonjoins it, perGOVERNANCE.md"Editor and Tasks" for a repository shipping Python. Nothing in the repository tracks that file.Verification
prose_lint.py --diff,docker_lint.py(actionlint included), andrepo_gate.py --check sha-pinpass, apart from the vendored PaperMod theme's own pins that CI excludes.frontiertier. The first raised that the aggregator comment no longer named which run takes the bound name, fixed infa24b50.🤖 Generated with Claude Code